Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typescript): file arrays call appendFile #4787

Merged
merged 3 commits into from
Oct 1, 2024
Merged

fix(typescript): file arrays call appendFile #4787

merged 3 commits into from
Oct 1, 2024

Conversation

dsinghvi
Copy link
Member

@dsinghvi dsinghvi commented Oct 1, 2024

Fix: File array uploads now call request.appendFile instead of request.append which was causing form data to be in a corrupted state.

RohinBhargava
RohinBhargava approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@RohinBhargava RohinBhargava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me; are there any other containers that might need this as well?

@dsinghvi dsinghvi merged commit 0fddeb2 into main Oct 1, 2024
45 of 47 checks passed
@dsinghvi dsinghvi deleted the dsinghvi/fix-file-arrays branch October 1, 2024 19:25
kbill-fern pushed a commit that referenced this pull request Oct 1, 2024
@dsinghvi @kbill-fern
fix(typescript): file arrays call appendFile (#4787)
31e9dc6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RohinBhargava RohinBhargava RohinBhargava approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsinghvi @RohinBhargava