Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): file arrays call appendFile #4787

Merged
merged 3 commits into from
Oct 1, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions generators/typescript/sdk/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.40.8] - 2024-09-28

- Fix: File array uploads now call `request.appendFile` instead of `request.append` which
was causing form data to be in a corrupted state.

## [0.40.7] - 2024-09-28

- Fix: The generated README will now have a section that links to the generated
Expand Down
2 changes: 1 addition & 1 deletion generators/typescript/sdk/VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.40.7
0.40.8
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export function appendPropertyToFormData({
),
ts.factory.createBlock(
[
context.coreUtilities.formDataUtils.append({
context.coreUtilities.formDataUtils.appendFile({
referencetoFormData: referenceToFormData,
key: property.key.wireValue,
value: ts.factory.createIdentifier(FOR_LOOP_ITEM_VARIABLE_NAME)
Expand Down
1 change: 1 addition & 0 deletions packages/cli/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@
"@fern-api/fern-definition-formatter": "workspace:*",
"@fern-api/cli-migrations": "workspace:*",
"@fern-api/fern-definition-schema": "workspace:*",
"@fern-typescript/fetcher": "workspace:*",
"@fern-fern/generators-sdk": "0.109.0-21be2e5be",
"@fern-fern/fiddle-sdk": "0.0.584",
"@types/get-port": "^4.2.0",
Expand Down
5 changes: 5 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading