Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cells while table loading #14947

Conversation

thethunderturner
Copy link
Contributor

@thethunderturner thethunderturner commented Nov 30, 2024

Description

Closes #7294, reopens #13961. As @zepfietje mentioned, further research needs to be made to check if it works with disabled attribute.

EDIT: It appears to be working. Also made a minor UI change for the disabled state of the select column (I showed after and before).

Visual changes

2024-12-01.03-36-48.mp4

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@danharrin
Copy link
Member

Hi, sorry but this is a v4 PR

@danharrin danharrin closed this Dec 1, 2024
@thethunderturner
Copy link
Contributor Author

thethunderturner commented Dec 1, 2024

Hi, sorry but this is a v4 PR

Cant I just change the target branch to 4.x @danharrin? Why close it?

@danharrin
Copy link
Member

It won't merge into v4 as the column views dont exist in v4

@thethunderturner
Copy link
Contributor Author

It won't merge into v4 as the column views dont exist in v4

Understood. I will make a fix for v4 then. Thanks for elaborarating

@thethunderturner thethunderturner mentioned this pull request Dec 1, 2024
3 tasks
@thethunderturner thethunderturner deleted the feature/disable-cells-while-loading branch December 2, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Disable interactive table cells while loading
2 participants