Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: curio seal: Fix partial Finalize retry #11730

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 17, 2024

Related Issues

For now on top of #11664, will rebase to master once that has landed.

Proposed Changes

This PR fixes an edge-case in Curio finalize where somehow first try may not fully execute all steps, and on retry we'd already see some data moved. Observed on my SP setup, also confirmed the fix works.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@magik6k magik6k force-pushed the fix/curio-fin-fixes branch from 586f1a5 to cf275bf Compare March 17, 2024 12:08
@magik6k magik6k force-pushed the fix/curio-fin-fixes branch from cf275bf to ad302e8 Compare March 17, 2024 16:43
@magik6k magik6k force-pushed the feat/lpdeal-cache branch from 3046186 to 154cf09 Compare March 17, 2024 19:04
@magik6k magik6k marked this pull request as ready for review March 18, 2024 18:13
Base automatically changed from feat/lpdeal-cache to master March 18, 2024 20:13
storage/paths/local.go Outdated Show resolved Hide resolved
@magik6k magik6k force-pushed the fix/curio-fin-fixes branch from ad302e8 to 62cbeb8 Compare March 22, 2024 14:17
@magik6k magik6k merged commit e86d81b into master Mar 22, 2024
96 of 98 checks passed
@magik6k magik6k deleted the fix/curio-fin-fixes branch March 22, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants