chore: f3: Upgrade to latest go-f3 v0.0.4

[masih]

Related Issues

#12236

Proposed Changes

Upgrade to the latest go F3, with fix to default cert exchange config in local devnet.

Additional Info

None

Checklist

Before you mark the PR ready for review, please make sure that:

• Commits have a clear commit message.
• PR title is in the form of of <PR type>: <area>: <change being made>
  • example: fix: mempool: Introduce a cache for valid signatures
  • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
  • area, e.g. api, chain, state, mempool, multisig, networking, paych, proving, sealing, wallet, deps
• Update CHANGELOG.md or signal that this change does not need it.
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • If the change does not require a CHANGELOG.md entry, do one of the following:
    • Add [skip changelog] to the PR title
    • Add the label skip/changelog to the PR
• New features have usage guidelines and / or documentation updates in
  • Lotus Documentation
  • Discussion Tutorials
• Tests exist for new functionality or change in behavior
• CI is green

[Stebalien]

Note: this also changes the manifest protocol. But we haven't deployed that server yet so we should be fine.

[rvagg]

@masih both MinimumPollInterval and MaximumPollInterval are based on DefaultEcConfig.ECPeriod in go-f3 but we don't reset them here. Should we? I believe they come out the same here as long as BlockDelaySecs is 30. How much do these matter to align to epoch length?

[masih]

I believe they come out the same here as long as BlockDelaySecs is 30

I think regardless of what BlockDelaySecs is set to cert exchange min max would be 30s and 2m respectively, because their value is instantiated via DefaultCxConfig var using DefaultEcConfig.ECPeriod.

For example, this passes for me.

import (
	"testing"
	"time"

	"github.com/filecoin-project/go-f3/manifest"
)

func TestMinMaxPollIntervalIsNotOverridden(t *testing.T) {
	m := manifest.LocalDevnetManifest()
	m.ECPeriod = 1
	if m.CxConfig.MinimumPollInterval != 30*time.Second {
		t.Fatalf("min ain't it")
	}
	if m.CxConfig.MaximumPollInterval != 4*30*time.Second {
		t.Fatalf("max ain't it")
	}
}

How much do these matter to align to epoch length?

Cert exchange internally optimises for the right poll time. As long as min and max are a wide enough interval of time, and min is not less than an epoch we should be good.

@Stebalien does that sound right?