Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ui: add a terminal check #12256

Merged
merged 1 commit into from
Jul 24, 2024
Merged

chore: ui: add a terminal check #12256

merged 1 commit into from
Jul 24, 2024

Conversation

jennijuju
Copy link
Member

@jennijuju jennijuju commented Jul 18, 2024

Related Issues

#12247 (comment)

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • Update CHANGELOG.md or signal that this change does not need it.
    • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
    • If the change does not require a CHANGELOG.md entry, do one of the following:
      • Add [skip changelog] to the PR title
      • Add the label skip/changelog to the PR
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@jennijuju jennijuju added the skip/changelog This change does not require CHANGELOG.md update label Jul 18, 2024
@jennijuju
Copy link
Member Author

cc @ribasushi

@jennijuju jennijuju force-pushed the jen/dontletwafflebreakthings branch 2 times, most recently from 758df42 to e87ef2f Compare July 18, 2024 02:34
@jennijuju jennijuju force-pushed the jen/dontletwafflebreakthings branch from e87ef2f to 753a33a Compare July 19, 2024 03:24
@ribasushi
Copy link
Collaborator

@rvagg @jennijuju this should land in master soon - it makes the already-in-master #12247 safer.

@rvagg rvagg merged commit 4cf04dc into master Jul 24, 2024
79 checks passed
@rvagg rvagg deleted the jen/dontletwafflebreakthings branch July 24, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants