Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip changelog] chore: drand: cleanup legacy and unused configs #12272

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

ribasushi
Copy link
Collaborator

@ribasushi ribasushi commented Jul 22, 2024

Related Issues

#10476

Proposed Changes

{"level":"info","ts":"2024-07-09T15:36:34.379+1000","logger":"drand","caller":"client/optimizing.go:194","msg":"","optimizing_client":"endpoint down when speed tested","client":"HT
TP(\"https://api.drand.secureweb3.com:6875/\").(+verifier)","err":"decoding response: EOF"}

Additional Info

@ribasushi ribasushi changed the title Chore/drand cleanup [skip changelog] chore: drand: cleanup legacy and unused configs Jul 22, 2024
@ribasushi ribasushi marked this pull request as ready for review July 22, 2024 14:39
@rvagg
Copy link
Member

rvagg commented Jul 23, 2024

As mentioned on Slack: I'm concerned that removing these configs impact clients syncing the chain from before the epochs where we've bumped the drand beacon. We're on quicknet now as per nv22 but if you wanted to sync prior to quicknet then I think you might need the config for mainnet? And then there's Incentinet used even earlier in the network's life too. Is it necessary to have access to these to sync? Could we make more headway on this issue by attacking how the clients are instantiated and only do it on demand:

func BeaconScheduleFromDrandSchedule(dcs dtypes.DrandSchedule, genesisTime uint64, ps *pubsub.PubSub) (beacon.Schedule, error) {
- i.e. we have one client for each network, so we have 3 for mainnet running now and 2 for calibnet.

@ribasushi
Copy link
Collaborator Author

@rvagg we definitely should not do what you suggested. As I said: youu concern is not applicable, and is easy to validate either way. As luck would have it I currently need a one-time stock-lotus sync of calibnet, which I just started.
image

as you can see on the right this is running 1.28.1-dev+calibnet+git.4803c0481+api1.5.0 which corresponds to the head of this commit. Stock from-scratch config with the 4 envvars as specified:

LOTUS_API_LISTENADDRESS="/ip4/127.0.0.1/tcp/12347/http" 
LOTUS_CHAIN_BADGERSTORE_DISABLE_FSYNC=1
LOTUS_DISABLE_PRE_MIGRATIONS=1
LOTUS_CHAINSTORE_ENABLESPLITSTORE=0

I wil comment again in a bit once the headers are synced and oce the network moves past its first several upgrades as per schedule

@ribasushi
Copy link
Collaborator Author

About 1 hour to get the headers
image
Upgraded up through 🦈
image

I will let it run to finish, some time tomorrow, but it clearly works. Can haz ✅ ?

build/buildconstants/drand.go Outdated Show resolved Hide resolved
Co-authored-by: AnomalRoil <[email protected]>
@ZenGround0 ZenGround0 merged commit 4cf5ca6 into filecoin-project:master Jul 23, 2024
77 checks passed
@ribasushi ribasushi deleted the chore/drand_cleanup branch July 23, 2024 16:47
@rvagg
Copy link
Member

rvagg commented Aug 23, 2024

#12414 is apparently one result of removing the network config, we've still been using it to look up per-epoch beacons with StateGetBeaconEntry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants