-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skip changelog] chore: drand: cleanup legacy and unused configs #12272
[skip changelog] chore: drand: cleanup legacy and unused configs #12272
Conversation
As mentioned on Slack: I'm concerned that removing these configs impact clients syncing the chain from before the epochs where we've bumped the drand beacon. We're on quicknet now as per nv22 but if you wanted to sync prior to quicknet then I think you might need the config for mainnet? And then there's Incentinet used even earlier in the network's life too. Is it necessary to have access to these to sync? Could we make more headway on this issue by attacking how the clients are instantiated and only do it on demand: lotus/chain/beacon/drand/drand.go Line 239 in 1b06f5e
|
@rvagg we definitely should not do what you suggested. As I said: youu concern is not applicable, and is easy to validate either way. As luck would have it I currently need a one-time stock-lotus sync of calibnet, which I just started. as you can see on the right this is running
I wil comment again in a bit once the headers are synced and oce the network moves past its first several upgrades as per schedule |
Co-authored-by: AnomalRoil <[email protected]>
#12414 is apparently one result of removing the network config, we've still been using it to look up per-epoch beacons with |
Related Issues
#10476
Proposed Changes
mainnet
just like it was done forincentinet
in fix: build: drop drand incentinet servers #10476. This will stop network clients being built for the unused network and will resolve spurious errors like:devnet
configAdditional Info