Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): pin and update dependencies #73

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

joe128
Copy link
Contributor

@joe128 joe128 commented Sep 11, 2024

The dependencies have not been updated for a while. I updated it and tested it with all of the example bot's use cases.
I also tested whether the dependencies could be changed using renovate and it worked (see master/renovate.json).
I have also created a dev container, if you are interested I can create another PR (see addDevContainer).

@filipre
Copy link
Owner

filipre commented Sep 12, 2024

Hi! Thank you! Do these updates require us to jump from Python 3.9 to Python 3.12? In general, I'd only bump the version if we require a new feature from that version or we are closer to EOL.

@joe128
Copy link
Contributor Author

joe128 commented Sep 12, 2024

No, it also works with older Python versions (Unit-tests runs with both 3.9.20 - the version of the project, and with 3.11.10 - the one with which the tests are supposed to run).
But in my opinion, it is always beneficial to use current versions and if you want to consider renovate-bot, the Python version would also be updated.
The missing point in my test with renovate would be updating the Python-version in the github-workflow-actions "setup-python", but that shouldn't be a problem.
edit: it was no probelm, see master/renovate.json, i didn't got all python-updates grouped, but i think that is only a cosmetic defect

@joe128
Copy link
Contributor Author

joe128 commented Oct 2, 2024

I have now also adapted the workflow files so that the tasks should run under Python 3.12.7.
But if you prefer to stay on python 3.11, I also created a PR for it (#74 )

Copy link
Collaborator

@Era-Dorta Era-Dorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @joe128, thanks a lot for the PR. After looking at #74, I'd prefer to merge this instead.

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@Era-Dorta Era-Dorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the addressing the comments.

@Era-Dorta Era-Dorta merged commit 8da39b2 into filipre:master Dec 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants