-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): pin and update dependencies #73
Conversation
Hi! Thank you! Do these updates require us to jump from Python 3.9 to Python 3.12? In general, I'd only bump the version if we require a new feature from that version or we are closer to EOL. |
No, it also works with older Python versions (Unit-tests runs with both 3.9.20 - the version of the project, and with 3.11.10 - the one with which the tests are supposed to run). |
I have now also adapted the workflow files so that the tasks should run under Python 3.12.7. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the addressing the comments.
The dependencies have not been updated for a while. I updated it and tested it with all of the example bot's use cases.
I also tested whether the dependencies could be changed using renovate and it worked (see master/renovate.json).
I have also created a dev container, if you are interested I can create another PR (see addDevContainer).