Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/pin dependencies python311 #74

Closed
wants to merge 2 commits into from

Conversation

joe128
Copy link
Contributor

@joe128 joe128 commented Oct 2, 2024

Pinned and updated Dependencies with python 3.11.10 if if you decide not to upgrade to 3.12

@Era-Dorta
Copy link
Collaborator

It's bad practice to pin dependencies directly in the pyproject.toml. That is what the poetry lock file is there for. You can update the pinned dependencies there by running poetry lock. If updating any is required or desired in the pyproject.toml, at least you should keep the "^" in front of the version number.

@joe128
Copy link
Contributor Author

joe128 commented Oct 7, 2024

I agree with you about normal poetry projects. But if you want to use the renovate-bot, it is suggested to pin the dependencies in the pyproject.toml (see warning under https://docs.renovatebot.com/modules/manager/poetry/).
Anyway, I would like to use the signalbot-project with current dependencies, if @filipre don't want to use the renovate-bot, I can push another PR with caret-requirements.

@Era-Dorta Era-Dorta closed this Dec 11, 2024
@Era-Dorta
Copy link
Collaborator

#73 was merged, so this is not useful anymore

@joe128 joe128 deleted the chore/pinDependenciesPython311 branch December 11, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants