Alternative graphics for NC empty state #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We currently used a “happy phone” icon for the empty Notification Centre tab. This was designed for FINN.no and does not fit with the Tori look and feel.
What?
Replace the notification center empty personal view icon for Tori, using ImageProvider.
Corresponding PR ios-app for branded version of icon: https://github.schibsted.io/finn/ios-app/pull/5078
Corresponding PR for notificaion-center-ios: https://github.schibsted.io/finn/notification-center-ios/pull/99
Jira task: https://nmp-jira.atlassian.net/browse/NMPAPP-924?atlOrigin=eyJpIjoiZmM2ZDg1MzAzMzIzNDJmODk2NGQyMWE0OGUzMmMyMjYiLCJwIjoiaiJ9
Version Change
Minor.
Changelog
Internal: Replaced icon shown to Tori users when they have no personal notifications.
UI Changes