Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative graphics for NC empty state #1343

Merged
merged 2 commits into from
May 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"images" : [
{
"filename" : "emptyPersonalNotifications.pdf",
"idiom" : "universal"
}
],
"info" : {
"author" : "xcode",
"version" : 1
}
}
Binary file not shown.
2 changes: 2 additions & 0 deletions FinniversKit/Sources/Assets/ImageAsset.swift
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ enum ImageAsset: String {
case easterEgg
case edit
case editBig
case emptyPersonalNotifications
case error
case exclamationMarkTriangleMini
case favoriteActive
Expand Down Expand Up @@ -204,6 +205,7 @@ enum ImageAsset: String {
.easterEgg,
.edit,
.editBig,
.emptyPersonalNotifications,
.error,
.exclamationMarkTriangleMini,
.favoriteActive,
Expand Down
5 changes: 5 additions & 0 deletions FinniversKit/Sources/DNA/Images/ImageProvider.swift
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ public protocol ImageProvider {

// General
var placeholderAd: UIImage { get }
var brandEmptyPersonalNotifications: UIImage { get }
var brandFavouriteAdd: UIImage { get }
var brandFavouriteAdded: UIImage { get }
var brandFavouriteAddImg: UIImage { get }
Expand Down Expand Up @@ -121,4 +122,8 @@ public struct DefaultImageProvider: ImageProvider {
public var brandMapDirections: UIImage {
UIImage(named: .mapDirections)
}

public var brandEmptyPersonalNotifications: UIImage {
UIImage(named: .emptyPersonalNotifications)
}
}
4 changes: 4 additions & 0 deletions FinniversKit/Sources/DNA/Images/UIImage+FinniversKit.swift
Original file line number Diff line number Diff line change
Expand Up @@ -85,4 +85,8 @@ import UIKit
class var brandLogo: UIImage {
Config.imageProvider.brandLogo
}

class var brandEmptyPersonalNotifications: UIImage {
Config.imageProvider.brandEmptyPersonalNotifications
}
}