Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change Package children to be set of PackageableElement instead of array for performance #965

Closed
wants to merge 2 commits into from

Conversation

MauricioUyaguari
Copy link
Member

@MauricioUyaguari MauricioUyaguari commented Mar 18, 2022

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2022

🦋 Changeset detected

Latest commit: f240ebe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@finos/legend-graph Patch
@finos/legend-query Patch
@finos/legend-server-depot Patch
@finos/legend-studio Patch
@finos/legend-application Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-external-format-json-schema Patch
@finos/legend-extension-external-language-morphir Patch
@finos/legend-extension-external-store-service Patch
@finos/legend-manual-tests Patch
@finos/legend-studio-extension-query-builder Patch
@finos/legend-taxonomy Patch
@finos/legend-query-app Patch
@finos/legend-studio-app Patch
@finos/legend-studio-extension-management-toolkit Patch
@finos/legend-taxonomy-app Patch
@finos/legend-graph-extension-collection Patch
@finos/legend-query-deployment Patch
@finos/legend-studio-deployment Patch
@finos/legend-taxonomy-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@finos-cla-bot finos-cla-bot bot added the cla-present CLA Signed label Mar 18, 2022
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #965 (f240ebe) into master (b138cf1) will increase coverage by 0.00%.
The diff coverage is 68.75%.

@@           Coverage Diff           @@
##           master     #965   +/-   ##
=======================================
  Coverage   42.84%   42.84%           
=======================================
  Files         967      967           
  Lines       44249    44262   +13     
  Branches    10276    10280    +4     
=======================================
+ Hits        18957    18966    +9     
- Misses      25218    25222    +4     
  Partials       74       74           
Impacted Files Coverage Δ
...kages/legend-server-depot/src/DepotServerClient.ts 0.00% <ø> (ø)
...ckages/legend-query/src/stores/LegendQueryStore.ts 19.71% <28.57%> (+0.29%) ⬆️
...amodels/pure/packageableElements/domain/Package.ts 81.39% <100.00%> (ø)
...rc/models/protocols/pure/v1/V1_PureGraphManager.ts 62.20% <100.00%> (+0.21%) ⬆️
...kages/legend-studio/src/stores/EditorGraphState.ts 40.89% <100.00%> (+0.44%) ⬆️

@MauricioUyaguari MauricioUyaguari force-pushed the profileTest branch 3 times, most recently from 05c84ad to 46638be Compare March 18, 2022 20:30
@MauricioUyaguari MauricioUyaguari changed the title WIP add profile test change Package children to be set of PackageableElement instead of array for performance Mar 18, 2022
@MauricioUyaguari MauricioUyaguari marked this pull request as ready for review March 18, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant