Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra] Enable client_app / client-app-cocoapods job #11914

Merged
merged 14 commits into from
Oct 12, 2023
Merged

[Infra] Enable client_app / client-app-cocoapods job #11914

merged 14 commits into from
Oct 12, 2023

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Oct 9, 2023 •
edited
Loading

Context

  • Objective-C++ import tests have been disabled due to C++ issues affecting Xcode versions before 14.3. We had to wait for Ventura (which is required for 14.3) to land on GHA so we could enable these on CI. Edit: We did not need to wait for Ventura. I had passed the -fcxxmodules flag which led to issues pre-Xcode 14.3 BUT that flag shouldn't be used by clients because C++ modules are not really stable. So, when removing the -fcxxmodules flag (and the test file that tested module imports in a C++ context), the weird issues that made me originally want to wait for running on 14.3 are no longer relevant.

#no-changelog

@ncooke3
Copy link
Member Author

ncooke3 commented Oct 9, 2023 •
edited
Loading

Expecting at least one failure related to using a modular import in an AppCheck public header (I reproduced such failure locally).

@ncooke3 ncooke3 mentioned this pull request Oct 11, 2023
Merged
@ncooke3 ncooke3 mentioned this pull request Oct 11, 2023
Merged
ncooke3 and others added 14 commits October 11, 2023 19:46
@ncooke3 ncooke3 changed the title [Infra] Enable tests now that GHA supports Xcode 14.3 [Infra] Enable client_app / client-app-cocoapods job Oct 11, 2023
@ncooke3 ncooke3 requested a review from paulb777 October 11, 2023 23:55
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseRemoteConfig-iOS-FirebaseRemoteConfig.framework

    Overall coverage changed from ? (43ced86) to 73.88% (176cac0) by ?.

    13 individual files with coverage change

    FilenameBase (43ced86)Merge (176cac0)Diff
    FIRConfigValue.m?58.70%?
    FIRRemoteConfig.m?83.91%?
    FIRRemoteConfigComponent.m?97.06%?
    FIRRemoteConfigUpdate.m?100.00%?
    RCNConfigContent.m?81.90%?
    RCNConfigDBManager.m?76.43%?
    RCNConfigExperiment.m?86.55%?
    RCNConfigFetch.m?74.13%?
    RCNConfigRealtime.m?50.63%?
    RCNConfigSettings.m?62.81%?
    RCNDevice.m?81.29%?
    RCNPersonalization.m?89.74%?
    RCNUserDefaultsManager.m?98.43%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/btZD3iR8Dp.html

@ncooke3 ncooke3 enabled auto-merge (squash) October 12, 2023 01:04
@ncooke3
Copy link
Member Author

ncooke3 commented Oct 12, 2023

Resolved convos and turned on auto-submit.

@ncooke3 ncooke3 merged commit 1ca98ff into master Oct 12, 2023
60 checks passed
@ncooke3 ncooke3 deleted the nc/ventura-ci branch October 12, 2023 01:54
@ncooke3 ncooke3 mentioned this pull request Oct 13, 2023
Merged
@mikehardy
Copy link
Contributor

Worth leaving a kudos for not just fixing my AppCheck C++ compile error but doing the usually unsung Proper Software Engineering Work of making sure the testing rig repro'd it and then the fix actually fixed the automated tests etc. I already appreciate the permanent quality improvement :-)

@ncooke3
Copy link
Member Author

ncooke3 commented Oct 17, 2023

Thanks @mikehardy! 🙂

@firebase firebase locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: remoteconfig
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ncooke3 @google-oss-bot @mikehardy @paulb777