-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release Tooling] Add resources, if any, to bundle within xcframework platform slices (approach 1) #12114
Conversation
ncooke3
commented
Nov 18, 2023
•
edited
Loading
edited
- This PR should only affect privacy manifests to maintain Xcode 14 compat.
- Test if SPM accepts xcframeworks with embedded resources (since there was that gRPC issue with the bundle at the root of the xcframework). If there's an issue, it may be fixed by signing the xcframework
Generated by 🚫 Danger |
d0c35f3
to
09ce6f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we need this for 10.21.0 now that GTMSessionFetcher has a privacy manifest.
Anything else needed to be done before merging?
Yes, the issue with this PR is that it changes the DevX for zip customers still using Xcode 14. As of the latest release, the Firebase.zip has three resources:
These resources are moved inside the xcframework they correspond to, so the integration instructions will be more complex (e.g. "for each of these SDKs that contain non-privacy manifest related resource bundles, copy the resource bundle out of a platform slice and add it to your app". I have some work locally I did a few weeks back that changes this PR's implementation to do the following:
This alternative approach is Xcode 14 friendly. |
Thanks. I believe we can drop the gRPC resource file since Firestore doesn't use it - it gets the contents from code. That would address #9184 and reduce the usability impact of this change. |