Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release Tooling] Validation workaround for Xcode 15.3b3 #12439

Merged
merged 3 commits into from
Feb 28, 2024
Merged

[Release Tooling] Validation workaround for Xcode 15.3b3 #12439

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a073445
[Release Tooling] Validation workaround for Xcode 15.3b3
ncooke3 Feb 27, 2024
4b61504
style
ncooke3 Feb 27, 2024
07c9368
Add comment
ncooke3 Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ReleaseTooling/Sources/ZipBuilder/FrameworkBuilder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,7 +671,18 @@ struct FrameworkBuilder {
fatalError("Could not copy fat binary to framework directory for \(framework): \(error)")
}
do {
try fileManager.copyItem(at: infoPlist, to: infoPlistDestination)
var plistDictionary = try PropertyListSerialization.propertyList(
from: Data(contentsOf: infoPlist), format: nil
) as! [AnyHashable: Any]
plistDictionary["MinimumOSVersion"] = "100.0"

let updatedPlistData = try PropertyListSerialization.data(
fromPropertyList: plistDictionary,
format: .binary,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may want to make this .xml in the future. The binary format is harder to diff from the command line. I'll change it if there is more plist related work down the road.

options: 0
)

try updatedPlistData.write(to: infoPlistDestination)
} catch {
// The Catalyst and macos Info.plist's are in another location. Ignore failure.
}
Expand Down
Loading