-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release Tooling] Validation workaround for Xcode 15.3b3 #12439
Conversation
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after comment, green CI and confirm that we don't do something strange on catalyst and macos like writing a one-line plist file.
Framework-level
|
|
||
let updatedPlistData = try PropertyListSerialization.data( | ||
fromPropertyList: plistDictionary, | ||
format: .binary, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may want to make this .xml
in the future. The binary format is harder to diff from the command line. I'll change it if there is more plist related work down the road.
sorry to bother you if you're busy, but quick question: you say above:
and also in the code:
i'm just curious what "b/327020913" is ... is that some internal google bug tracker reference? the reason i ask is, i'm in the process of trying to work through a similar issue with a 3rd-party library vendor (best available ref here; sorry, the actual vendor doesn't track issues on github), and their contention is that the issue is caused by an apple bug ... so i'm curious if you guys also consider this to be an apple bug that you're trying to work around, or do you feel it's just stricter (but not erroneous) checking on the part of xcode 15.3? if you have time for a quick reply, i'd appreciate it. |
Yes. The "b" reference is an internal bug tracker and yes we consider it an Apple bug: Apple should allow SDKs to support a lower minimum OS version than the app and it's very strange that setting the version higher than any available OS is a workaround. |
thanks for the response! surely someone somewhere has filed a radar on this (although how would one ever know?). |
We have an open Apple Feedback about the issue and still waiting for a response. |
Feedback (Radar) ID: FB13657402 |
context in b/327020913
Validated locally by building one xcframework. It's possible this could blow up when building all of the xcframeworks, but hopefully not.