fix the sign in with deleted passkey crash issue #12710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Apple API Diff ReportCommit: b8f7136 FirebaseAuthEnumerationsFIRAuthErrorCode[ADDED] FIRAuthErrorCodePasskeyEnrollmentNotFoundSwift:
+ case passkeyEnrollmentNotFound = 17209
Objective-C:
+ FIRAuthErrorCodePasskeyEnrollmentNotFound = 17209 |
renkelvin
approved these changes
Apr 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the public facing ERROR_PASSKEY_ENROLLMENT_NOT_FOUND error
Fix the app crashing issue after sign in with a already removed passkey. The issue was due to after receiving the error, we kept going with the sign in. Added the return statement after error has been received.