-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix(ai): Fix fraction seconds bug with ProtoDuration #15410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a bug in ProtoDuration decoding where the fractional part of a second was misinterpreted. The addition of unit tests is also a great improvement to prevent future regressions. My review includes a suggestion to use Decimal instead of Double for the nanosecond calculation to make it more robust against floating-point inaccuracies. I've also added some minor suggestions to improve the new tests by specifying accuracy for floating-point comparisons.
This PR fixes a minor bug I came across in the
ProtoDurationdecoding. It's not a emergency release worthy bug, but it can produce an incorrect nanosecond value (ie; instead of123000000it currently produces123). In practicality, this means that withinLiveServerGoingAwayNotice, thetimeLeftfield could be off by +-1 second.Tests have been added for
ProtoDurationas well, to help avoid this in the future.