Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eady equations and problems #451

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Eady equations and problems #451

wants to merge 11 commits into from

Conversation

tommbendall
Copy link
Contributor

@tommbendall tommbendall commented Oct 6, 2023 •
edited
Loading

The aim of this is to finally get the Eady equations/problems working again.

The main things to highlight are:

  • the addition of two new equations
  • two examples have been added to the examples directory
  • there are several new diagnostics (many of which are useful more generally). These have been added to the existing diagnostics.py module rather than being in their own module
  • the routines for setting the initial v field are now in the examples files
  • the TrueResidualV diagnostic should still work, as we can point to the value of the velocity from the start of the timestep

@tommbendall tommbendall marked this pull request as ready for review October 8, 2023 19:06
colinjcotter
colinjcotter reviewed Apr 18, 2024
View reviewed changes
gusto/configuration.py Outdated
"""
Physical parameters for Incompressible Eady
"""
Nsq = 2.5e-05 # squared Brunt-Vaisala frequency (1/s)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably a bit dangerous to have N and Nsq both in the parameters with inconsistent values.

@tommbendall tommbendall added enhancement Involves adding a new capability research problem Involves new science, with possibly unknown outcome external issue Pull requests or issues relating to an external issue labels Aug 7, 2024
@tommbendall tommbendall added equation Adding or enhancing a new equation example For adding or updating an example and removed enhancement Involves adding a new capability labels Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinjcotter colinjcotter colinjcotter left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
equation Adding or enhancing a new equation example For adding or updating an example external issue Pull requests or issues relating to an external issue research problem Involves new science, with possibly unknown outcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tommbendall @colinjcotter