Fix mountain test through specification of initial wind #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mountain_nonhydrostatic
test is currently broken, as it calls theremove_initial_w
routine which no longer works, giving the error message:This PR fixes that by simply not calling the
remove_initial_w
routine. Instead we enforce the no-normal flow boundary conditions through the initial projection of the wind.The final state demonstrates that this still gives the correct initial condition: