Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mountain test through specification of initial wind #31

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Fix mountain test through specification of initial wind #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25fb713
fix mountain through specification of initial wind
tommbendall Nov 21, 2024
719cb23
update plotting script and figure
tommbendall Nov 22, 2024
d1c1134
Merge branch 'main' into TBendall/FixMountainRemoveW
tommbendall Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions case_studies/compressible_euler/mountain_nonhydrostatic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
CompressibleEulerEquations, OutputParameters, IO, SSPRK3,
DGUpwind, SemiImplicitQuasiNewton, compressible_hydrostatic_balance,
SpongeLayerParameters, Exner, ZComponent, Perturbation,
SUPGOptions, TrapeziumRule, remove_initial_w, MaxKernel, MinKernel
SUPGOptions, TrapeziumRule, MaxKernel, MinKernel
)

mountain_nonhydrostatic_defaults = {
Expand Down Expand Up @@ -220,8 +220,7 @@ def mountain_nonhydrostatic(

theta0.assign(theta_b)
rho0.assign(rho_b)
u0.project(as_vector([initial_wind, 0.0]))
remove_initial_w(u0)
u0.project(as_vector([initial_wind, 0.0]), bcs=eqns.bcs['u'])

stepper.set_reference_profiles([('rho', rho_b), ('theta', theta_b)])

Expand Down
Binary file modified figures/compressible_euler/mountain_nonhydrostatic_final.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion plotting/compressible_euler/plot_mountain_nonhydrostatic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
# When copying this example these paths need editing, which will usually involve
# removing the abspath part to set directory paths relative to this file
results_file_name = f'{abspath(dirname(__file__))}/../../results/{test}/field_output.nc'
plot_stem = f'{abspath(dirname(__file__))}/../figures/{test}'
plot_stem = f'{abspath(dirname(__file__))}/../../figures/compressible_euler/{test}'

# ---------------------------------------------------------------------------- #
# Final plot details
Expand Down
Loading