add -Woverloaded-virtual warning (#45)

fixposition · Nov 7, 2024 · 7b59b93 · 7b59b93
1 parent f3393a4
commit 7b59b93
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 18 deletions.
diff --git a/fpsdk_apps/CMakeLists.txt b/fpsdk_apps/CMakeLists.txt
@@ -13,9 +13,8 @@ project(fpsdk_apps
 # COMPILER SETUP =======================================================================================================
 
 set(CMAKE_CXX_STANDARD 14)
-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic\
-    -Wshadow -Wunused-parameter -Wformat -Wpointer-arith\
-    -Werror")
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic -Werror \
+    -Wshadow -Wunused-parameter -Wformat -Wpointer-arith -Woverloaded-virtual")
 set(CMAKE_CXX_FLAGS_RELEASE "-O3")
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 if(NOT CMAKE_BUILD_TYPE)

diff --git a/fpsdk_common/CMakeLists.txt b/fpsdk_common/CMakeLists.txt
@@ -13,9 +13,8 @@ project(fpsdk_common
 # COMPILER SETUP =======================================================================================================
 
 set(CMAKE_CXX_STANDARD 14)
-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic\
-    -Wshadow -Wunused-parameter -Wformat -Wpointer-arith\
-    -Werror")
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic -Werror \
+    -Wshadow -Wunused-parameter -Wformat -Wpointer-arith -Woverloaded-virtual")
 set(CMAKE_CXX_FLAGS_RELEASE "-O3")
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 if(NOT CMAKE_BUILD_TYPE)

diff --git a/fpsdk_ros1/CMakeLists.txt b/fpsdk_ros1/CMakeLists.txt
@@ -13,9 +13,8 @@ project(fpsdk_ros1
 # COMPILER SETUP =======================================================================================================
 
 set(CMAKE_CXX_STANDARD 14)
-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic\
-    -Wshadow -Wunused-parameter -Wformat -Wpointer-arith\
-    -Werror")
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic -Werror \
+    -Wshadow -Wunused-parameter -Wformat -Wpointer-arith -Woverloaded-virtual")
 set(CMAKE_CXX_FLAGS_RELEASE "-O3")
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 if(NOT CMAKE_BUILD_TYPE)

diff --git a/fpsdk_ros2/CMakeLists.txt b/fpsdk_ros2/CMakeLists.txt
@@ -14,9 +14,8 @@ project(fpsdk_ros2
 
 set(CMAKE_CXX_STANDARD 17) # ROS2 needs this, it seems
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic\
-    -Wshadow -Wunused-parameter -Wformat -Wpointer-arith\
-    -Werror")
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic -Werror \
+    -Wshadow -Wunused-parameter -Wformat -Wpointer-arith -Woverloaded-virtual")
 set(CMAKE_CXX_FLAGS_RELEASE "-O3")
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 if(NOT CMAKE_BUILD_TYPE)

diff --git a/ros1_fpsdk_demo/CMakeLists.txt b/ros1_fpsdk_demo/CMakeLists.txt
@@ -12,9 +12,8 @@ project(ros1_fpsdk_demo
 # COMPILER SETUP =======================================================================================================
 
 set(CMAKE_CXX_STANDARD 14)
-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic\
-    -Wshadow -Wunused-parameter -Wformat -Wpointer-arith\
-    -Werror")
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic -Werror \
+    -Wshadow -Wunused-parameter -Wformat -Wpointer-arith -Woverloaded-virtual")
 set(CMAKE_CXX_FLAGS_RELEASE "-O3")
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 if(NOT CMAKE_BUILD_TYPE)

diff --git a/ros2_fpsdk_demo/CMakeLists.txt b/ros2_fpsdk_demo/CMakeLists.txt
@@ -13,9 +13,8 @@ project(ros2_fpsdk_demo
 
 # TODO: The ament stuff overrides some of these...?
 set(CMAKE_CXX_STANDARD 17)
-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic\
-    -Wshadow -Wunused-parameter -Wformat -Wpointer-arith\
-    -Werror")
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic -Werror \
+    -Wshadow -Wunused-parameter -Wformat -Wpointer-arith -Woverloaded-virtual")
 set(CMAKE_CXX_FLAGS_RELEASE "-O3")
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 if(NOT CMAKE_BUILD_TYPE)