Fix silently failing test

flatironinstitute · Nov 21, 2024 · d65b76d · d65b76d
1 parent 73f404c
commit d65b76d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/tests/test_slurm/run.sh b/tests/test_slurm/run.sh
@@ -1,5 +1,7 @@
 #!/bin/bash
 
+set -e
+
 workdir=$(mktemp -d -p ./ disbatch-test.XXXX)
 cp Tasks $workdir
 cd $workdir
@@ -9,8 +11,8 @@ salloc -n 2 disBatch Tasks
 
 # Check that all 3 tasks ran,
 # which means A.txt, B.txt, and C.txt exist
-[[ -f A.txt && -f B.txt && -f C.txt ]]
-success=$?
+success=0
+[[ -f A.txt && -f B.txt && -f C.txt ]] || success=$?
 
 cd - > /dev/null
 

diff --git a/tests/test_ssh/Tasks_failfast b/tests/test_ssh/Tasks_failfast
@@ -0,0 +1,3 @@
+sleep 1000
+exit 1
+touch A.txt
diff --git a/tests/test_ssh/run.sh b/tests/test_ssh/run.sh
@@ -1,5 +1,7 @@
 #!/bin/bash
 
+set -e
+
 workdir=$(mktemp -d -p ./ disbatch-test.XXXX)
 cp Tasks Tasks_failfast $workdir
 cd $workdir