Output driven parallelism #663
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
DiamonDinoia
commented
Apr 21, 2025
•
DiamonDinoia
commented
- Output Driven initial implementation
- Binsize tuning
- Parameter tuning
- Optimized interp
* Fixed test timing issue
* Some tests in cmake were asking for too many digits give the size of the transform * Cufinufft suffered from a off-by-one error since the original implementation. Fixed for now.
…driven-parallelism
|
@janden if you could have a look at the python issue and then review? |
DiamonDinoia
requested review from
blackwer and
janden
and removed request for
blackwer
|
Performance summary:
|
|
|
|
Just noting that I am unavailable for reviews until about May 15. Looking
forward to seeing the performance when back in office!
…On Monday, May 5, 2025, Marco Barbone ***@***.***> wrote:
*DiamonDinoia* left a comment (flatironinstitute/finufft#663)
<#663 (comment)>
image.png (view on web)
<https://github.com/user-attachments/assets/015186df-b704-4e06-a1e7-90dd1358fe94>
—
Reply to this email directly, view it on GitHub
<#663 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACY7UWE2ABW6WNY64ARRGD2464SRAVCNFSM6AAAAAB3R6T2U2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNJSGEZDSOBXG4>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.