Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vuln dashboard: Update Okta SSO hook #17773

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Vuln dashboard: Update Okta SSO hook #17773

merged 2 commits into from
Mar 22, 2024

Conversation

eashaw
Copy link
Contributor

@eashaw eashaw commented Mar 21, 2024 •
edited
Loading

Closes: #17772
More context: #17601 (comment)

Changes:

  • Updated the order of the vulnerability dashboard's HTTP middleware if Okta SSO is enabled.

@fleet-release fleet-release added the ~ceo PR requesting review from the CEO or issue related to EA tasks label Mar 21, 2024
mikermcneil
mikermcneil approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@mikermcneil mikermcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record: Let's avoid using passportjs.

@eashaw eashaw merged commit 413107b into main Mar 22, 2024
7 checks passed
@eashaw eashaw deleted the vulnerability-dashboard-update-okatsso-hook branch March 22, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikermcneil mikermcneil mikermcneil approved these changes

Assignees
No one assigned
Labels
~ceo PR requesting review from the CEO or issue related to EA tasks
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability dashboard bug: Upgraded Okta SSO middleware throws errors.
3 participants
@eashaw @mikermcneil @fleet-release