Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vuln dashboard: Update Okta SSO hook #17773

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Vuln dashboard: Update Okta SSO hook #17773

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d535fa
Vulnerability dashboard: Update order of middleware to prevent errors…
eashaw Mar 21, 2024
acda3d7
reaname hook, add comments
eashaw Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...lity-dashboard/api/hooks/OktaSSO/index.js → ...ity-dashboard/api/hooks/okta-sso/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ module.exports = function (sails){
}

// Clone the existing routes
// NOTE: Changing sails.config after the app lifts goes against Sails.js conventions and this code should not be reproduced.
let appRoutes = Object.assign({}, sails.config.routes);
// Remove the routes for the built-in login page..
delete appRoutes['GET /login'];
Expand All @@ -45,9 +46,9 @@ module.exports = function (sails){
'bodyParser',
'compress',
'poweredBy',
'www',// Note: This changes the conventions of Sails.js. Don't ever replicate this or use Passport.js.
'oktaSSO',
'router',
'www',
'favicon',
];
// Specify a custom http middleware order, placing the Okta middleware before the router. This is so the routes generated by Okta will take precedence over the sails router.
Expand Down
Loading