Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load bar for large files #2559

Merged
merged 7 commits into from
Jan 27, 2025
Merged

Conversation

julien-louis
Copy link
Collaborator

@julien-louis julien-louis commented Dec 18, 2024

problem : when dowloading large files and / or with a slow network, nothing seem to happen. Actually the file is fully downloaded silently, then the brwser dl menu is triggered.

  • Here a progress bar in the left side menu his displayed if the dl takes more than 5s.
  • If trying to leave the page during a download a confirmation is asked
  • if quit / reload the page, the download is aborted and the notification is gone

@julien-louis julien-louis marked this pull request as ready for review December 19, 2024 15:36
@michaelkain
Copy link
Contributor

Hi @DuckflipXYZ, I hope you are doing fine.
This is an interesting feature, especially for our ongoing challenge MS-Multi-Spine, as downloads of big zip files can be very long. It would be great to test and merge it. With kind regards, Michael

Copy link
Collaborator

@DuckflipXYZ DuckflipXYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All functionalities linked to the feature work correctly. Tested by downloading a subject

@DuckflipXYZ DuckflipXYZ merged commit fb0fd8c into fli-iam:develop Jan 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants