feat: expose honorLabels key in ServiceMonitor #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andi4000
force-pushed
the
feat/honor-labels-servicemonitor
branch
from
e10cc59 to
d023b42
Compare
|
It looks great @andi4000! Could you bump minor version in Chart.yaml for me please? |
andi4000
force-pushed
the
feat/honor-labels-servicemonitor
branch
from
eff6e20 to
6532e4d
Compare
Done :) |
GeorgeMac
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion: https://community.flipt.io/t/prometheus-as-source-for-analytics/58/11
Prometheus config defaults to
false, so this PR would not change any behaviour.