Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose honorLabels key in ServiceMonitor #195

Merged
merged 2 commits into from
Dec 12, 2024
Merged

feat: expose honorLabels key in ServiceMonitor #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d023b42
feat: expose honorLabels key in ServiceMonitor
andi4000 Dec 11, 2024
6532e4d
chore: bump chart minor version
andi4000 Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/flipt/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: flipt
home: https://flipt.io
description: Flipt is an open-source, self-hosted feature flag solution.
type: application
version: 0.76.1
version: 0.77.0
appVersion: v1.53.1
maintainers:
- name: Flipt
Expand Down
1 change: 1 addition & 0 deletions charts/flipt/templates/servicemonitor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ spec:
interval: {{ . }}
{{- end }}
path: /metrics
honorLabels: {{ .Values.metrics.serviceMonitor.honorLabels }}
{{- with .Values.metrics.serviceMonitor.relabelings }}
relabelings:
{{- toYaml . | nindent 8 }}
Expand Down
3 changes: 3 additions & 0 deletions charts/flipt/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,9 @@ metrics:
# -- ServiceMonitor relabel configs to apply to samples before scraping
# https://github.com/prometheus-operator/prometheus-operator/blob/master/Documentation/api.md#relabelconfig
relabelings: []
# -- What to do when flipt metrics labels are conflicting with Prometheus server-side labels.
# true means keep label values from flipt.
honorLabels: false
# -- ServiceMonitor will use http by default, but you can pick https as well
scheme: http
# -- ServiceMonitor will use these tlsConfig settings to make the health check requests
Expand Down
Loading