-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create generator for wall mounted (spice) rack #573
Conversation
Sorry for the late response. This summer was a bit rough. This looks actually pretty good already and has a surprisingly rich set of features. Some minor nitpicks:
If you don't want to do those yourself after half a year I can handle them. Having a good photo would be very nice though. Just attaching it here is fine with me, though. |
No problem. I am still interested in finishing this up.
Thanks for taking the time to look through my PR |
After starting to write an answer I figured it would be quicker to just make the changes myself. The vertical_edges setting ususally turns the F edges at the corners of a box into h edges (finger holes) for more stability. It's not necessary to add this feature before merging this PR. This can still be done later on. Either by you or by myself or not at all. It's not too difficult but touches a few places and needs special care at the bottom to not mess things up - especially when From my POV this is ready to be merged. If you don't mind I would just squash the patches and merge. |
Ok, added the parameter back. Set the default to finger holes as this is much stronger. It also will make the bottom flat by default without any drawbacks. flat_bottom and F side_edges now puts the holes of the bottom row right at the edge - basically emulating an F edge. |
A wall mounted (spice) rack
8ae2a7f
to
42d4beb
Compare
OK, merge after a bit of tweaking of the sizes when using If you can submit a nice sample picture either as an PR or attaching here or in #140 that would be very much appreciated. Other than that: Thanks for your patience and your work! |
Picture got added with 8411b7f |
I still want to tweak this a bit and maybe add some more customisation options, but wanted to create this PR to get some feedback on if the implementation looks ok.
This adds a new generator that creates a wall mounted rack/shelf to store p.e. spices. (at least that is why I created it, because I needed something like that in my kitchen).
Features:
Photo of my Prototype (not suitable to be the example picture. I will add better photos once the PR is done: