Fix bug when creating Fastqs in mock analysis projects without specifying lanes #914
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjbriggs
force-pushed
the
mock-fix-setting-lane-in-Fastq-headers
branch
from
cc784b2 to
41e4405
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the
MockAnalysisProject.createmethod (in themockmodule) when making Fastqs without explicitly specifying a lane in the names (e.g. because merging across lanes is being simulated).Without the fix the Fastq read headers have the lane set to
None(creating an invalid read header and potentially breaking code which tries to extract information from it). The fix is to have the lane number default to1if not otherwise specified.