pass connection options to postgresql client #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Turkalp Burak Kayrancıoğlu <[email protected]>
This was referenced Feb 12, 2023
sxd
reviewed
Mar 11, 2023
Signed-off-by: Turkalp Burak Kayrancioglu <[email protected]>
|
hi @sxd I updated PR and added comment. |
Signed-off-by: Turkalp Burak Kayrancioglu <[email protected]>
pipeline/outputs/postgresql.md
Outdated
| @@ -56,6 +56,7 @@ Make sure that the `fluentbit` user can connect to the `fluentbit` database on t | |||
| | `Password` | Password of PostgreSQL username | - | | |||
| | `Database` | Database name to connect to | - \(current user\) | | |||
| | `Table` | Table name where to store data | - | | |||
| | `Connection_Options` | PostgreSQL connection options | - | | |||
There was a problem hiding this comment.
Any restrictions on content? Should we quote anything with spaces in, etc?
There was a problem hiding this comment.
no, it allows string with spaces.
ex: passing multiple options:
Connection_Options -c geqo=off -c statement_timeout=0
There was a problem hiding this comment.
Can you update with clarification then, i.e. a link to what is allowed.
There was a problem hiding this comment.
I was updated. Could you check again please?
Signed-off-by: Türkalp Burak Kayrancıoğlu <[email protected]>
patrick-stephens
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fluent/fluent-bit#6836