Make SemanticsNode.isMergedIntoParent Readonly #6617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyHillers
requested review from
kenzieschmoll
and removed request for
a team
packages/devtools_app/lib/src/shared/primitives/custom_pointer_scroll_view.dart
Outdated
Show resolved
Hide resolved
|
Is this the correct fix @LongCatIsLooong ? Although not blocking roll since a fix for b/308325747 was already applied we still want this right? |
|
Yeah the fix LGTM. |
|
@kenzieschmoll can you take a look? This is going to block the Dart SDK roll into Google. Let me know if we need release notes for this change. For now, I'm going to mark it as exempt. |
Comment on lines
814
to
815
| _innerNode ??= SemanticsNode(showOnScreen: showOnScreen); | ||
| _innerNode! | ||
| ..isMergedIntoParent = node.isPartOfNodeMerging | ||
| ..rect = Offset.zero & node.rect.size; | ||
| _innerNode!.rect = Offset.zero & node.rect.size; |
There was a problem hiding this comment.
can we do instead what is done on flutter master?
(_innerNode ??= SemanticsNode(showOnScreen: showOnScreen)).rect = node.rect;
(Most of the code in this file is copied from scrollable.dart from the Flutter framework)
added 2 commits
October 31, 2023 15:19
kenzieschmoll
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from flutter/flutter#137304
Breaks Google testing (b/308325747)
Pre-launch Checklist
///).