Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SemanticsNode.isMergedIntoParent Readonly #6617

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Make SemanticsNode.isMergedIntoParent Readonly #6617

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
74771df
Make SemanticsNode.isMergedIntoParent Readonly
CaseyHillers Oct 29, 2023
7344822
Simplify unnecessary cascade operator
CaseyHillers Oct 30, 2023
ea26099
Kenzie Recomend
Oct 31, 2023
bb62a6f
fmt
Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/devtools_app/lib/src/shared/primitives/custom_pointer_scroll_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,9 +812,7 @@ class _RenderScrollSemantics extends RenderProxyBox {
}

_innerNode ??= SemanticsNode(showOnScreen: showOnScreen);
_innerNode!
..isMergedIntoParent = node.isPartOfNodeMerging
..rect = Offset.zero & node.rect.size;
_innerNode!.rect = Offset.zero & node.rect.size;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do instead what is done on flutter master?
(_innerNode ??= SemanticsNode(showOnScreen: showOnScreen)).rect = node.rect;

(Most of the code in this file is copied from scrollable.dart from the Flutter framework)


int? firstVisibleIndex;
final List<SemanticsNode> excluded = <SemanticsNode>[_innerNode!];
Expand Down
Loading