Skip to content

Commit

Permalink
fixing client ordering
Browse files Browse the repository at this point in the history
Signed-off-by: Daniel Rammer <[email protected]>
  • Loading branch information
hamersaw committed Jan 17, 2024
1 parent 674cdc0 commit c359d67
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions flytepropeller/pkg/controller/executors/kube.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,10 @@ var NewClient = func(config *rest.Config, options client.Options) (client.Client
return k8sClient, err
}

// TODO - should we wrap this in a writeThroughCachingWriter as well?
k8sOtelClient := otelutils.WrapK8sClient(k8sClient)
if reader != nil {
// once the k8s client is created we set the fallback reader's client to the k8s client
reader.orderedClients = append([]client.Reader{k8sOtelClient}, reader.orderedClients...)
reader.orderedClients = append(reader.orderedClients, k8sOtelClient)
}

return k8sOtelClient, nil
Expand Down

0 comments on commit c359d67

Please sign in to comment.