[flyteplugins] Make the TF Job Worker Spec Correct #4169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Future Outlier <[email protected]>
pingsutw
approved these changes
Oct 5, 2023
pingsutw
reviewed
Oct 5, 2023
| @@ -122,7 +122,7 @@ func (tensorflowOperatorResourceHandler) BuildResource(ctx context.Context, task | |||
| workerReplicaSpec := kfTensorflowTaskExtraArgs.GetWorkerReplicas() | |||
| if workerReplicaSpec != nil { | |||
| err := common.OverrideContainerSpec( | |||
| replicaSpecMap[kubeflowv1.MPIJobReplicaTypeWorker].PodSpec, | |||
| replicaSpecMap[kubeflowv1.TFJobReplicaTypeWorker].PodSpec, | |||
There was a problem hiding this comment.
Yes no problem, I will do it!
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4169 +/- ##
==========================================
+ Coverage 54.59% 59.29% +4.69%
==========================================
Files 178 550 +372
Lines 16038 39692 +23654
==========================================
+ Hits 8756 23535 +14779
- Misses 6568 13836 +7268
- Partials 714 2321 +1607
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
hamersaw
approved these changes
Oct 5, 2023
I can add it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
As title.
#4167