Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flyteplugins] Make the TF Job Worker Spec Correct #4169

Merged
merged 1 commit into from
Oct 5, 2023
Merged

[flyteplugins] Make the TF Job Worker Spec Correct #4169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flyteplugins/go/tasks/plugins/k8s/kfoperators/tensorflow/tensorflow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ func (tensorflowOperatorResourceHandler) BuildResource(ctx context.Context, task
workerReplicaSpec := kfTensorflowTaskExtraArgs.GetWorkerReplicas()
if workerReplicaSpec != nil {
err := common.OverrideContainerSpec(
replicaSpecMap[kubeflowv1.MPIJobReplicaTypeWorker].PodSpec,
replicaSpecMap[kubeflowv1.TFJobReplicaTypeWorker].PodSpec,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add a test for it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes no problem, I will do it!

kubeflowv1.TFJobDefaultContainerName,
workerReplicaSpec.GetImage(),
workerReplicaSpec.GetResources(),
Expand Down
Loading