Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence NotFound when get task resource #4388

Merged
merged 4 commits into from
Nov 11, 2023

Fix more places

e147cc5
Select commit
Loading
Failed to load commit list.
Merged

Silence NotFound when get task resource #4388

Fix more places
e147cc5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 9, 2023 in 0s

60.70% (+0.51%) compared to bda9aca

View this Pull Request on Codecov

60.70% (+0.51%) compared to bda9aca

Details

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (bda9aca) 60.18% compared to head (e147cc5) 60.70%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4388      +/-   ##
==========================================
+ Coverage   60.18%   60.70%   +0.51%     
==========================================
  Files         252      434     +182     
  Lines       21595    35790   +14195     
==========================================
+ Hits        12997    21726    +8729     
- Misses       7540    12346    +4806     
- Partials     1058     1718     +660     
Files Coverage Δ
flyteadmin/pkg/errors/errors.go 62.50% <100.00%> (+3.67%) ⬆️
flyteadmin/pkg/manager/impl/util/shared.go 64.40% <100.00%> (-0.16%) ⬇️
.../pkg/manager/impl/executions/quality_of_service.go 62.12% <0.00%> (ø)
flyteadmin/pkg/manager/impl/executions/queues.go 85.71% <0.00%> (-6.35%) ⬇️
flyteadmin/pkg/manager/impl/util/resources.go 90.66% <0.00%> (ø)
...g/executioncluster/impl/random_cluster_selector.go 76.92% <0.00%> (-0.20%) ⬇️
flyteadmin/pkg/manager/impl/execution_manager.go 70.54% <40.00%> (+<0.01%) ⬆️

... and 182 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.