-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor task logs framework #4396
Conversation
Signed-off-by: Jeev B <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4396 +/- ##
==========================================
- Coverage 58.14% 57.95% -0.20%
==========================================
Files 466 396 -70
Lines 40047 29233 -10814
==========================================
- Hits 23287 16943 -6344
+ Misses 14875 10575 -4300
+ Partials 1885 1715 -170
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it's clear to me the distinction between the two packages ATM?
Cleared up confusion offline. These changes do not add any extra packages. They simply cleanup existing ones. However, the lines between the |
…are specified Signed-off-by: Jeev B <[email protected]>
Describe your changes
TemplateLogPluginConfig
andTemplateLogPlugin
logPlugin
struct in favor ofTemplateLogPlugin
{{.generatedName}}
as a template variable in theTaskExecution
schemeGetTaskLog
method, and cleanup/consolidate associated testsCheck all the applicable boxes
Setup Process
Screenshots
Note to reviewers
Related PRs