Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken link from Understand How Flyte Handles Data page #4518

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

neverett
Copy link
Contributor

@neverett neverett commented Dec 1, 2023

Docs link

Changed docs link: https://flyte--4518.org.readthedocs.build/en/4518/concepts/data_management.html#bringing-in-your-own-datastores-for-raw-data

I removed the link from "data persistence layer".

Describe your changes

Removes broken link from "Bringing in Your Own Datastores for Raw Data" section of "Understand How Flyte Handles Data" docs page.

Check all the applicable boxes

  • All new and existing tests passed.
  • All commits are signed-off.

Signed-off-by: nikki everett <[email protected]>
@neverett neverett added bug Something isn't working documentation Improvements or additions to documentation labels Dec 1, 2023
@neverett neverett requested a review from ppiegaze December 1, 2023 22:38
@neverett neverett self-assigned this Dec 1, 2023
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 1, 2023
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (475e9d0) 59.37% compared to head (e36cefe) 59.40%.

❗ Current head e36cefe differs from pull request most recent head 948bb29. Consider uploading reports for the commit 948bb29 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4518      +/-   ##
==========================================
+ Coverage   59.37%   59.40%   +0.02%     
==========================================
  Files         638      638              
  Lines       53961    53957       -4     
==========================================
+ Hits        32039    32052      +13     
+ Misses      19391    19376      -15     
+ Partials     2531     2529       -2     
Flag Coverage Δ
unittests 59.40% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@neverett
Copy link
Contributor Author

neverett commented Dec 1, 2023

@eapolinario I'm not sure what the codecov/project test is, but it's the only one that's not passing -- is there something I need to do to get it to pass?

@neverett neverett changed the title remove broken link Remove broken link from Understand How Flyte Handles Data page Dec 1, 2023
@neverett neverett requested a review from samhita-alla December 5, 2023 20:53
@eapolinario eapolinario enabled auto-merge (squash) December 5, 2023 21:04
@eapolinario eapolinario merged commit 350bb2b into master Dec 5, 2023
43 checks passed
@eapolinario eapolinario deleted the nikki-remove-broken-link branch December 5, 2023 21:13
pvditt pushed a commit that referenced this pull request Dec 13, 2023
Signed-off-by: nikki everett <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Paul Dittamo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants