Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flytepropeller] Watch agent metadata service dynamically #5460

Merged
merged 41 commits into from
Jun 28, 2024

Add test for agent watcher

8fc782f
Select commit
Loading
Failed to load commit list.
Merged

[flytepropeller] Watch agent metadata service dynamically #5460

Add test for agent watcher
8fc782f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jun 23, 2024 in 1s

43.10% of diff hit (target 61.01%)

View this Pull Request on Codecov

43.10% of diff hit (target 61.01%)

Annotations

Check warning on line 71 in flyteplugins/go/tasks/pluginmachinery/core/plugin.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/core/plugin.go#L68-L71 

Added lines #L68 - L71 were not covered by tests

Check warning on line 78 in flyteplugins/go/tasks/pluginmachinery/core/plugin.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/core/plugin.go#L75-L78 

Added lines #L75 - L78 were not covered by tests

Check warning on line 134 in flyteplugins/go/tasks/plugins/webapi/agent/client.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/webapi/agent/client.go#L134 

Added line #L134 was not covered by tests

Check warning on line 150 in flyteplugins/go/tasks/plugins/webapi/agent/client.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/webapi/agent/client.go#L148-L150 

Added lines #L148 - L150 were not covered by tests

Check warning on line 62 in flyteplugins/go/tasks/plugins/webapi/agent/plugin.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/webapi/agent/plugin.go#L59-L62 

Added lines #L59 - L62 were not covered by tests

Check warning on line 237 in flyteplugins/go/tasks/plugins/webapi/agent/plugin.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/webapi/agent/plugin.go#L237 

Added line #L237 was not covered by tests

Check warning on line 333 in flyteplugins/go/tasks/plugins/webapi/agent/plugin.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/webapi/agent/plugin.go#L333 

Added line #L333 was not covered by tests

Check warning on line 338 in flyteplugins/go/tasks/plugins/webapi/agent/plugin.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/webapi/agent/plugin.go#L336-L338 

Added lines #L336 - L338 were not covered by tests

Check warning on line 388 in flyteplugins/go/tasks/plugins/webapi/agent/plugin.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/webapi/agent/plugin.go#L388 

Added line #L388 was not covered by tests

Check warning on line 393 in flyteplugins/go/tasks/plugins/webapi/agent/plugin.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/webapi/agent/plugin.go#L392-L393 

Added lines #L392 - L393 were not covered by tests

Check warning on line 403 in flyteplugins/go/tasks/plugins/webapi/agent/plugin.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/webapi/agent/plugin.go#L403 

Added line #L403 was not covered by tests

Check warning on line 405 in flyteplugins/go/tasks/plugins/webapi/agent/plugin.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/webapi/agent/plugin.go#L405 

Added line #L405 was not covered by tests

Check warning on line 411 in flyteplugins/go/tasks/plugins/webapi/agent/plugin.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/webapi/agent/plugin.go#L411 

Added line #L411 was not covered by tests

Check warning on line 414 in flyteplugins/go/tasks/plugins/webapi/agent/plugin.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/webapi/agent/plugin.go#L414 

Added line #L414 was not covered by tests

Check warning on line 253 in flytepropeller/pkg/controller/nodes/task/handler.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/controller/nodes/task/handler.go#L253 

Added line #L253 was not covered by tests

Check warning on line 349 in flytepropeller/pkg/controller/nodes/task/handler.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/controller/nodes/task/handler.go#L349 

Added line #L349 was not covered by tests
View more details on Codecov