Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flytepropeller] Watch agent metadata service dynamically #5460

Merged
merged 41 commits into from
Jun 28, 2024

Add test for agent watcher

8fc782f
Select commit
Loading
Failed to load commit list.
Merged

[flytepropeller] Watch agent metadata service dynamically #5460

Add test for agent watcher
8fc782f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jun 23, 2024 in 0s

60.99% (-0.03%) compared to 87db0a3

View this Pull Request on Codecov

60.99% (-0.03%) compared to 87db0a3

Details

Codecov Report

Attention: Patch coverage is 43.10345% with 33 lines in your changes missing coverage. Please review.

Project coverage is 60.99%. Comparing base (87db0a3) to head (8fc782f).
Report is 3 commits behind head on master.

❗ Current head 8fc782f differs from pull request most recent head 0803569

Please upload reports for the commit 0803569 to get more accurate results.

Files Patch % Lines
...yteplugins/go/tasks/plugins/webapi/agent/plugin.go 46.66% 16 Missing ⚠️
...yteplugins/go/tasks/pluginmachinery/core/plugin.go 0.00% 8 Missing ⚠️
...yteplugins/go/tasks/plugins/webapi/agent/client.go 64.28% 4 Missing and 1 partial ⚠️
...lytepropeller/pkg/controller/nodes/task/handler.go 33.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5460      +/-   ##
==========================================
- Coverage   61.01%   60.99%   -0.03%     
==========================================
  Files         794      794              
  Lines       51441    51454      +13     
==========================================
- Hits        31387    31382       -5     
- Misses      17162    17180      +18     
  Partials     2892     2892

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov