Minor cleanup for Web API plugins #5472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sovietaced
commented
Jun 11, 2024
| @@ -54,9 +54,6 @@ type State struct { | |||
| // level retries, just errors from hitting API, inside the sync loop | |||
| SyncFailureCount int `json:"syncFailureCount,omitempty"` | |||
|
|
|||
| // In creating the resource, this is the number of failures | |||
| CreationFailureCount int `json:"creationFailureCount,omitempty"` | |||
There was a problem hiding this comment.
Creation failure is not increment/used
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5472 +/- ##
==========================================
- Coverage 60.97% 60.97% -0.01%
==========================================
Files 793 793
Lines 51331 51331
==========================================
- Hits 31299 31298 -1
- Misses 17147 17148 +1
Partials 2885 2885
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jason Parraga <[email protected]>
Signed-off-by: Jason Parraga <[email protected]>
Sovietaced
force-pushed
the
unused-plugin-code
branch
from
5b76da3 to
7288aa8
Compare
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
Signed-off-by: Jason Parraga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request just cleans up some confusing/unused field as well as a documentation fix for the Web API plugin contract.