Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup for Web API plugins #5472

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Minor cleanup for Web API plugins #5472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
102516f
Remove unused creation failure counter
Sovietaced Jun 11, 2024
7288aa8
Remove reference to k8s plugin
Sovietaced Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions flyteplugins/go/tasks/pluginmachinery/internal/webapi/state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,6 @@ type State struct {
// level retries, just errors from hitting API, inside the sync loop
SyncFailureCount int `json:"syncFailureCount,omitempty"`

// In creating the resource, this is the number of failures
CreationFailureCount int `json:"creationFailureCount,omitempty"`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creation failure is not increment/used


// The time the execution first requests for an allocation token
AllocationTokenRequestStartTime time.Time `json:"allocationTokenRequestStartTime,omitempty"`

Expand Down
2 changes: 1 addition & 1 deletion flyteplugins/go/tasks/pluginmachinery/webapi/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (
// that the plugin loader will be called before any Handle/Abort/Finalize functions are invoked
type PluginLoader func(ctx context.Context, iCtx PluginSetupContext) (AsyncPlugin, error)

// PluginEntry is a structure that is used to indicate to the system a K8s plugin
// PluginEntry is a structure that is used to indicate to the system a WebAPI plugin
type PluginEntry struct {
// ID/Name of the plugin. This will be used to identify this plugin and has to be unique in the entire system
// All functions like enabling and disabling a plugin use this ID
Expand Down
Loading