-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unauthenticated Rust Flytekit Remote Client Task endpoints #2414
Merged
pingsutw
merged 20 commits into
flyteorg:flyrs
from
austin362667:austin362667/flyrs/remote/task_apis
May 15, 2024
Merged
Add unauthenticated Rust Flytekit Remote Client Task endpoints #2414
pingsutw
merged 20 commits into
flyteorg:flyrs
from
austin362667:austin362667/flyrs/remote/task_apis
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]> add no-auth caveat Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]> lint Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
austin362667
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
May 14, 2024 18:59
3 tasks
pingsutw
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
austin362667
added a commit
to austin362667/flytekit
that referenced
this pull request
May 15, 2024
…org#2414) Signed-off-by: Austin Liu <[email protected]>
This was referenced Jun 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#5344
Why are the changes needed?
This PR aims to be the first subtask that validates the feasibility of replacing Python gRPC with Rust one.
What changes were proposed in this pull request?
As a minimum viable PR, we target at end-to-end testing without authentication, and again it supports Task endpoints only at the present time.
Add a flag
enable_rust
to the FlyteRemote class. When this flag is true, FlyteRemote will use the rust implementation.4 task-related APIs in
flytekit/clients/friendly_rs.py
andflyrs/src/lib.py
,create_task()
list_task_ids_paginated()
list_tasks_paginated()
get_task()
The communication between
flytekit.remote
(Python)flyrs.FlyteRemote
(Rust) is throrugh serialization/deserialization as bytes string.How was this patch tested?
Setup process
Please walk through #2415 .
Screenshots
Check all the applicable boxes
Related PRs
Docs link