-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GA workflow to test Rust Remote without installing Python gRPC #2415
Merged
pingsutw
merged 8 commits into
flyteorg:flyrs
from
austin362667:austin362667/flyrs/remote/ci_jobs
May 28, 2024
Merged
Add GA workflow to test Rust Remote without installing Python gRPC #2415
pingsutw
merged 8 commits into
flyteorg:flyrs
from
austin362667:austin362667/flyrs/remote/ci_jobs
May 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austin362667
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy and
samhita-alla
as code owners
May 14, 2024 19:02
austin362667
commented
May 14, 2024
3 tasks
austin362667
force-pushed
the
austin362667/flyrs/remote/ci_jobs
branch
7 times, most recently
from
May 15, 2024 10:07
2043481
to
78b1577
Compare
pingsutw
reviewed
May 15, 2024
austin362667
force-pushed
the
austin362667/flyrs/remote/ci_jobs
branch
from
May 19, 2024 08:18
bdf9501
to
68fc16a
Compare
3 tasks
austin362667
force-pushed
the
austin362667/flyrs/remote/ci_jobs
branch
10 times, most recently
from
May 21, 2024 18:46
bd3e74b
to
b1e64e1
Compare
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
Signed-off-by: Austin Liu <[email protected]>
austin362667
force-pushed
the
austin362667/flyrs/remote/ci_jobs
branch
from
May 22, 2024 13:49
bef8f95
to
62cde50
Compare
pingsutw
approved these changes
May 28, 2024
austin362667
added a commit
to austin362667/flytekit
that referenced
this pull request
Jun 15, 2024
…lyteorg#2415) Signed-off-by: Austin Liu <[email protected]>
austin362667
added a commit
to austin362667/flytekit
that referenced
this pull request
Jun 15, 2024
…lyteorg#2415) Signed-off-by: Austin Liu <[email protected]>
This was referenced Jun 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#5344
Why are the changes needed?
To add a integration test for the Rust Remote Client, we have to add Github Action Jobs for building and installing compiled Python extension,
flyrs
, from Rust through PyO3 bindings.What changes were proposed in this pull request?
Caution
This PR depends on the previous work done in #2414 .
It cannot be executed before #2414 is merged.
We add two CI/CD jobs,
build-without-grpcio
grpcio
,grpcio-status
.build-with-grpcio
Both of them are only being tested against integration test
test_rust_remote.py
that installedflyrs
viamaturin develop
(compiled and installed), and we skip tests if not found moduleflyrs
.How was this patch tested?
Run integration test by command:
pytest tests/flytekit/integration/remote/test_rust_remote.py
Github Action has been tested locally (on my personal forked repo's GA CI), please check the following screenshots.
Setup process
Caution
This PR depends on the previous work done in #2414 It cannot be merged before #2414 is merged.
Screenshots
test_rust_remote.py
if no Python grpc dependencies installed.Check all the applicable boxes
Related PRs
This PR depends on the previous work #2414.
Docs link