Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update struct for notification request #19

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hrishavkmr
Copy link

No description provided.

IOSContentAvailable bool `json:"content_available"`
IOSNotification IOSNotification `json:"notification"`
To []string `json:"to"`
Data map[string]interface{} `json:"data"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a good chance that some people might not actually use JSON, that's the reason I didn't want to have map, if you have a map, you need to parse into text and send that to pushy. What if they want to send an XML, may I know the reason for this?

also build failed.

Copy link
Author

@hrishavkmr hrishavkmr Jan 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushyMessage := pushy.SendNotificationRequest{
To: []string{<device_id>},
Data: `{"message":"hello world"}`,
}

I have tried using it like this, this doesn't work with pushy API. i get this error - Please supply the notification payload as a key-value object.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can fix the build, I'll test it and I'll merge if it works,

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or let me check this weekend if there's some new change in pushy's API, I was using this for a while and then I stopped doing android.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TravisCI build is failing for this reason - The command "go get -u golang.org/x/lint/golint" failed and exited with 2 during.
I think this is the same reason for which the last commit on the master was failing.
Any idea on how can we fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants