Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update struct for notification request #19

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update struct for notification request #19

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85c10c1
update struct for notification request
hrishavkmr Jan 15, 2021
a26d0c4
refactor: add error code in error struct
hrishavkmr Jan 18, 2021
24bd95a
fix: fix error code names
hrishavkmr Jan 18, 2021
1195c44
refactor: add more error codes
hrishavkmr Jan 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ type Pushy struct {

// Error are simple error responses returned from pushy if request isn't valid
type Error struct {
Code string `json:"code"`
Error string `json:"error"`
}

Expand Down Expand Up @@ -93,12 +94,12 @@ type DeviceSubscriptionRequest struct {

// SendNotificationRequest is representation of data to be sent to pushy service to create new notification
type SendNotificationRequest struct {
To []string `json:"to"`
Data string `json:"data"`
TimeToLive int `json:"time_to_live"`
IOSMutableContent bool `json:"mutable_content"`
IOSContentAvailable bool `json:"content_available"`
IOSNotification IOSNotification `json:"notification"`
To []string `json:"to"`
Data map[string]interface{} `json:"data"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a good chance that some people might not actually use JSON, that's the reason I didn't want to have map, if you have a map, you need to parse into text and send that to pushy. What if they want to send an XML, may I know the reason for this?

also build failed.

Copy link
Author

@hrishavkmr hrishavkmr Jan 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushyMessage := pushy.SendNotificationRequest{
To: []string{<device_id>},
Data: `{"message":"hello world"}`,
}

I have tried using it like this, this doesn't work with pushy API. i get this error - Please supply the notification payload as a key-value object.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can fix the build, I'll test it and I'll merge if it works,

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or let me check this weekend if there's some new change in pushy's API, I was using this for a while and then I stopped doing android.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TravisCI build is failing for this reason - The command "go get -u golang.org/x/lint/golint" failed and exited with 2 during.
I think this is the same reason for which the last commit on the master was failing.
Any idea on how can we fix this?

TimeToLive int `json:"time_to_live"`
IOSMutableContent bool `json:"mutable_content"`
IOSContentAvailable bool `json:"content_available"`
IOSNotification *IOSNotification `json:"notification"`
}

// IOSNotification is a basic data for notification for iOS devices
Expand Down Expand Up @@ -133,3 +134,14 @@ type IHTTPClient interface {
Post(string, string, io.Reader) (*http.Response, error)
Do(*http.Request) (*http.Response, error)
}

const (
ErrInvalidParam = "INVALID_PARAM"
ErrInvalidAuthKey = "INVALID_API_KEY"
ErrAuthLimitExcceded = "AUTH_LIMIT_EXCEEDED"
ErrAccountSuspended = "ACCOUNT_SUSPENDED"
ErrRateLimitExceeded = "RATE_LIMIT_EXCEEDED"
ErrInternalServerError = "INTERNAL_SERVER_ERROR"
ErrNoRecipents = "NO_RECIPIENTS"
ErrNoApnAuth = "NO_APNS_AUTH"
)