fix(fmt): account for CRLF when handling cursor #11874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xrusowsky
requested review from
DaniPopes,
mattsse,
grandizzy,
yash-atreya,
zerosnacks and
onbjerg
as code owners
0xrusowsky
commented
Sep 29, 2025
Comment on lines
+28
to
+31
| // Figure out if the cursor needs to check for CR (`\r`). | ||
| if let Some(item) = source_unit.items.first() { | ||
| self.check_crlf(item.span.to(source_unit.items.last().unwrap().span)); | ||
| } |
There was a problem hiding this comment.
i believe that initially checking if the file contains \r to then skip checking the sourcemap each time is more efficient, but feel free to push back if u disagree
DaniPopes
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes:
Solution
rather than blindly advancing the cursor by 1, we need to check if the current character is
\rto account for the whole CRLF sequence and advance 2 chars instead.PR Checklist