-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mcap info
prints channel metadata
#1000
Conversation
I really care about channel metadata being shown somehow in |
a9c34a3
to
8822869
Compare
IMO:
|
@b-camacho the I'm kind of skeptical this is a good feature for "info" - metadata can contain weird stuff like escaped yaml strings, not just simple key/values, that will make the output much worse unless you're asking for it. And seems like if you're asking for it, you need all of it. I wonder if maybe a better direction would be support for,
Seems like the combination of those would give you what you want (single call with all the info) in a more programmatically-consumable way - though maybe |
for ease of discussion, here's the "list channels" output for a converted ros1 bag, which contains all the stuff required in channel info for the ros1 mcap profile:
|
I didn't know about To make the discussion more concrete, consider this use case: I like the solution you proposed where the existing |
@james-rms what decisions are left on this PR to get this feature merged? seems like we need to decide on the feature flag. Might I propose |
Ah, I think we decided to add a bigger rework of the |
Seems like this work has gone stale? Do we still want to keep it open? |
Closing this since there was no response to my last inquiry. If you eventually come back to this we can revisit. |
Public-Facing Changes
mcap info
did not show channel metadata. Now it will print (up to 50 characters of) json-marshalled channel metadata.Description
Example output after this change on
tests/conformance/data/TenMessages/TenMessages-rch-rsh-st.mcap
:Before this change:
For channels that don't include metadata, there's no change in behavior
Motivation
At work, we use channel metadata to record which physical device a channel was recorded on. This means multiple channels can exist in the same mcap file with the same topic name. It's hard to distinguish between them without the channel metadata.